Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Interop-CI update #1679

Merged
merged 5 commits into from
Sep 15, 2023
Merged

[ci] Interop-CI update #1679

merged 5 commits into from
Sep 15, 2023

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Sep 15, 2023

Parent issue #866.

R/Python interop CI fails recently such as
https://github.com/single-cell-data/TileDB-SOMA/actions/runs/6192715614/job/16828946741

Error: [TileDB::Array] Error: [TileDB::ArrayDirectory] Error: ArraySchema: Failed to deserialize array schema: incompatible format version: got 20; expected <= 19

This simply means a writer is writing v20 and a reader is reading v19 -- "from the future". This in spite of the fact that we believe we've got core 2.17.0, tiledb-py 0.23, and tiledb-r 0.21 throughout.

I am debugging this.

The fix is to imitate existing-in-main r-ci.yaml; simple copypasta.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023

Codecov Report

Patch has no changes to coverable lines.

❗ Current head 37cd805 differs from pull request most recent head ed41e98. Consider uploading reports for the commit ed41e98 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

📢 Thoughts on this report? Let us know!.

@johnkerl
Copy link
Member Author

@johnkerl johnkerl changed the title Interop canary [WIP] Interop canary Sep 15, 2023
@johnkerl johnkerl marked this pull request as ready for review September 15, 2023 14:33
@johnkerl johnkerl changed the title Interop canary [ci] Interop-CI update Sep 15, 2023
Copy link
Contributor

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but maybe do one more pass of cleanups?

Copy link
Member

@nguyenv nguyenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for figuring this out.

@johnkerl
Copy link
Member Author

johnkerl commented Sep 15, 2023

Looks good but maybe do one more pass of cleanups?
@eddelbuettel thank you! :) 38b5d7d

@johnkerl
Copy link
Member Author

Thanks so much for figuring this out.

@nguyenv thank @eddelbuettel ! :)

@eddelbuettel
Copy link
Contributor

Well you could argue I put the source of the issue in (by accelerating our CI via binaries) and thought I had checked for this days ago. Sigh. But now fixed.

@johnkerl johnkerl merged commit 84e53e5 into main Sep 15, 2023
@johnkerl johnkerl deleted the kerl/interop-canary branch September 15, 2023 15:08
@@ -40,11 +40,11 @@ jobs:
- name: Install BioConductor package SingleCellExperiment
run: cd apis/r && tools/r-ci.sh install_bioc SingleCellExperiment

- name: Install rc version of tiledb-r (macOS)
- name: Install r-universe build of tiledb-r (macOS)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray quote marks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eek thx

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1681
Thank you @thetorpedodog ! :)

@johnkerl johnkerl mentioned this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants