-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c++] Depend on core 2.17.0 #1677
Conversation
Codecov ReportPatch has no changes to coverable lines.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is internally consistent in ensuring "2.17.0 and its resulting API packages shall be used".
But the practical problem is that we don't have them yet as binaries. Not at Conda (feedstock issue), not at r2u. We do have them at r-universe and as source at CRAN. Close but is it close enough?
Conda is for later in our release procedure: Green CI matters for this PR. This Python/R interop which has been solidly quietly green for months is now vexing me. |
I'll merge this PR as it fixes things needing fixed. But Python/R interop remains to be solved. |
I'll debug the interop first thing tomorrow. |
Issue and/or context: For #866. The "real" PRs are #1519, #1511, and #1559 which are at the moment depending on core 2.17.0-rc0. On this PR, if CI passes, I'll attempt to first merge solely the core-dependency change -- and then the big three PRs will be able to be rebased on top of this once it's merged.
Changes:
Notes for Reviewer: