Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Depend on core 2.17.0 #1677

Merged
merged 3 commits into from
Sep 15, 2023
Merged

[c++] Depend on core 2.17.0 #1677

merged 3 commits into from
Sep 15, 2023

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Sep 14, 2023

Issue and/or context: For #866. The "real" PRs are #1519, #1511, and #1559 which are at the moment depending on core 2.17.0-rc0. On this PR, if CI passes, I'll attempt to first merge solely the core-dependency change -- and then the big three PRs will be able to be rebased on top of this once it's merged.

Changes:

Notes for Reviewer:

@johnkerl johnkerl changed the title [c++] Depend on core 2.17.0 [WIP] [c++] Depend on core 2.17.0 [RFC] Sep 14, 2023
@johnkerl johnkerl marked this pull request as draft September 14, 2023 20:36
@johnkerl johnkerl changed the title [c++] Depend on core 2.17.0 [RFC] [c++] Depend on core 2.17.0 Sep 15, 2023
@johnkerl johnkerl marked this pull request as ready for review September 15, 2023 01:22
@johnkerl johnkerl mentioned this pull request Sep 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023

Codecov Report

Patch has no changes to coverable lines.

❗ Current head 897ce45 differs from pull request most recent head 9d10219. Consider uploading reports for the commit 9d10219 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is internally consistent in ensuring "2.17.0 and its resulting API packages shall be used".

But the practical problem is that we don't have them yet as binaries. Not at Conda (feedstock issue), not at r2u. We do have them at r-universe and as source at CRAN. Close but is it close enough?

@johnkerl
Copy link
Member Author

Conda is for later in our release procedure:
https://github.com/single-cell-data/TileDB-SOMA/wiki/Branches-and-releases

Green CI matters for this PR.

This Python/R interop which has been solidly quietly green for months is now vexing me.

@johnkerl
Copy link
Member Author

johnkerl commented Sep 15, 2023

I'll merge this PR as it fixes things needing fixed. But Python/R interop remains to be solved.

@johnkerl johnkerl merged commit 6b3c237 into main Sep 15, 2023
@johnkerl johnkerl deleted the kerl/use-2.17.0 branch September 15, 2023 01:53
@johnkerl
Copy link
Member Author

I'll debug the interop first thing tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants