Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Expand unit testing for enumerated types #1624

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Aug 18, 2023

Issue and/or context:

Parent issue #866

This PR is stacked atop #1511

Changes:

Notes for Reviewer:

In my sandbox I have checked out:

@johnkerl johnkerl force-pushed the kerl/categ-int-nan-python-test branch from 99fe7fe to 4c2f8db Compare August 18, 2023 18:14
@johnkerl
Copy link
Member Author

[sc-27923]

@johnkerl johnkerl force-pushed the kerl/categ-int-nan-python-test branch from 4c2f8db to e0846eb Compare August 18, 2023 18:35
@johnkerl johnkerl changed the title [python] Expand unit-testing for enumerated types [python] Expand unit testing for enumerated types Aug 21, 2023
@johnkerl johnkerl requested a review from nguyenv August 21, 2023 13:56
@johnkerl johnkerl marked this pull request as ready for review August 21, 2023 13:56
@johnkerl
Copy link
Member Author

@nguyenv I'd like you to merge this into #1511 -- this PR is against your branch on that PR

@nguyenv
Copy link
Member

nguyenv commented Aug 22, 2023

@nguyenv I'd like you to merge this into #1511 -- this PR is against your branch on that PR

OK can do.

@nguyenv nguyenv force-pushed the viviannguyen/sc-30316/enumerated-data-types-aka-categoricals-aka branch from c2c81de to a84e76c Compare August 24, 2023 02:44
…icals-aka' into kerl/categ-int-nan-python-test
@nguyenv nguyenv merged commit 5431512 into viviannguyen/sc-30316/enumerated-data-types-aka-categoricals-aka Aug 24, 2023
@nguyenv nguyenv deleted the kerl/categ-int-nan-python-test branch August 24, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants