Wrap Enumerated Datatype

[nguyenv]

Context: single-cell-data/TileDB-SOMA#866
Depends on: #4051

[shortcut-integration]

This pull request has been linked to Shortcut Story #30456: Bind Enumerated Data Type in TileDB-Py.

[nguyenv]

Errors are unrelated to changes in this PR. Fix is in #1793.

[nguyenv]

macOS runners (sans Python 3.7) are failing tiledb/tests/cc/test_cc.py::test_array. It is not reproducible on an EC2 macOS instance. Adding timestamps for writing and reading does not help. I do know how this is related to changes with Enumeration. I'll need to stop looking at this for now to work on adding Enumeration to TileDB-SOMA. Ultimately we do not even use the Pybind11 wrapped lt.Array in TileDB-Py yet; we are still using the Cython wrapped Array so fixing this issue is not highest priority.

[nguyenv]

On Windows we do not get to the step of installing TileDB-Py. It is erroring out when building libtiledb.

https://github.com/TileDB-Inc/TileDB-Py/actions/runs/5390955093/jobs/9787083896?pr=1790#step:13:408

D:\a\TileDB-Py\TileDB-Py\build\TileDB-d43f9123\tiledb\..\tiledb/sm/serialization/array_schema.h(129,43): error C3083: 'Enumeration': the symbol to the left of a '::' must be a type (compiling source file D:\a\TileDB-Py\TileDB-Py\build\TileDB-d43f9123\tiledb\sm\c_api\tiledb.cc) [D:\a\TileDB-Py\TileDB-Py\build\TileDB-d43f9123\build\tiledb\tiledb\TILEDB_CORE_OBJECTS.vcxproj] [D:\a\TileDB-Py\TileDB-Py\build\TileDB-d43f9123\build\tiledb.vcxproj

[johnkerl]

[sc-30316]

[shortcut-integration]

This pull request has been linked to Shortcut Story #30316: Enumerated data types AKA categoricals AKA factors.

[nguyenv]

Errors are unrelated to this PR. There is an ongoing fix in core for dimension labels on dense arrays.

[johnkerl]

@nguyenv can you please rebase this on top of today's dev? Or, I have already done so locally and can push my rebase -- if that's OK with you ...

[nguyenv]

Oh just noticed this comment. Please go ahead and push your changes.

[johnkerl]

@nguyenv I for the most recent CI fail I ran clang-format -i tiledb/query_condition.cc on my laptop & pushed but it doesn't like that. I'm missing some settings I think. I tried reverse-engineering a run-line from the CI job but my laptop doesn't like --clang-format-executable flag ... 🤔

[johnkerl]

pip install clang-format==10.0.1 to the rescue -- forget about apt et al. :)

[eddelbuettel]

pip install clang-format==10.0.1 to the rescue -- forget about apt et al. :)

Apparently clang-format-14 (which is one used by core) arrived in Ubuntu 22.04 and has been available in every release since: https://packages.ubuntu.com/search?suite=all&section=all&arch=any&keywords=clang-format-14&searchon=names

clang-format-10, if you really want it, was in 20.04: https://packages.ubuntu.com/search?keywords=clang-format-10&searchon=names&suite=all&section=all

(And I still don't understand why our script leaves it open, just calls the unversioned clang-format and sets us up for needless delta between version. Oh well.)

[ihnorton]

Release checks:

In [1]: import tiledb

In [2]: tiledb.version()
Out[2]: (0, 23, 0)

In [3]: tiledb.libtiledb.version()
Out[3]: (2, 17, 0)

In [4]: a = tiledb.open("s3://<...>/0.23.0-check")

In [5]: a[:]
Out[3]:
array([0.59115895, 0.60078051, 0.41469102, 0.57943571, 0.95046928,
...