Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct ASCII-to-Unicode readback for attribute_filter #141

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Jun 1, 2022

Context: #106

See also: #138 #101 #99

The idea is that:

  • For the next few months, pending an upcoming TileDB-core release, we'll be taking obs/var Unicode strings and storing them as "ASCII" which really means bytes -- "α,β,γ" stores as "\xce\xb1,\xce\xb2,\xce\xb3"
  • On readback of obs/var dataframes we decode back to "α,β,γ"
  • This was being done correctly on the AnnotationDataFrame's dim_select / df accessor; the same logic needs applied to its attribute_filter accessor

@johnkerl johnkerl requested review from aaronwolen and gspowley June 1, 2022 16:47
@johnkerl johnkerl mentioned this pull request Jun 1, 2022
61 tasks
@johnkerl johnkerl merged commit b15b94d into main Jun 1, 2022
@johnkerl johnkerl deleted the kerl/ascii-readback-test branch June 1, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants