Correct ASCII-to-Unicode readback for attribute_filter #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #106
See also: #138 #101 #99
The idea is that:
obs
/var
Unicode strings and storing them as "ASCII" which really means bytes -- "α,β,γ" stores as "\xce\xb1,\xce\xb2,\xce\xb3"obs
/var
dataframes we decode back to "α,β,γ"AnnotationDataFrame
'sdim_select
/df
accessor; the same logic needs applied to itsattribute_filter
accessor