Extend ASCII-queryability workaround #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronwolen
approved these changes
Jun 1, 2022
| @@ -163,15 +172,38 @@ def from_dataframe(self, dataframe: pd.DataFrame, extent: int) -> None: | |||
| if self._verbose: | |||
| print(f"{self._indent}Re-using existing array {self.uri}") | |||
|
|
|||
| # Context: https://github.com/single-cell-data/TileDB-SingleCell/issues/99. | |||
| # ISSUE: | |||
| # TileDB attributes can be stored as Unicode but they are not yet queryable via the TileDB | |||
This was referenced Jun 1, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: issue #99. (See also: issue #106 and PRs #101 and #117.)
As pointed out by @bkmartinjr in a Slack conversation, the selection of string columns to store as ASCII on #101 was artificial, and likely to cause confusion. The better approach he suggested was to do this to all string attributes.
This PR implements that better approach.
We will need this store-as-ASCII, decode-to-Unicode on read workaround for a couple months or so now pending some non-trivial work in TileDB core to fully support
QueryConditionlogic on Unicode attributes. As a reminder on the important of this workaround, string attributes are non-queryable unless they are stored as ASCII, until full core-level support is in place; cc @Shelnutt2 and @ihnorton.Note for @ebezzi and @bkmartinjr -- we will need a full re-ingest once this is merged and once TileDB-Inc/TileDB-Py#1110 is merged and deployed in a
TileDB-Pyrelease which we include here intiledbsc-py.