Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Add parameters to ExperimentAxis query methods #169

Merged
merged 3 commits into from
Jul 27, 2023
Merged

[python] Add parameters to ExperimentAxis query methods #169

merged 3 commits into from
Jul 27, 2023

Conversation

ebezzi
Copy link
Member

@ebezzi ebezzi commented Jul 26, 2023

Resolves single-cell-data/TileDB-SOMA#1527
Testing will done on tiledbsoma (link TBD)

@ebezzi ebezzi requested a review from bkmartinjr July 26, 2023 20:04
@ebezzi ebezzi changed the title Add parameters to experimentaxis query Add parameters to ExperimentAxis query methods Jul 26, 2023
@ebezzi ebezzi mentioned this pull request Jul 26, 2023
Merged
@johnkerl johnkerl changed the title Add parameters to ExperimentAxis query methods [python] Add parameters to ExperimentAxis query methods Jul 26, 2023
@ebezzi ebezzi requested review from johnkerl and pablo-gar July 26, 2023 20:16
@bkmartinjr bkmartinjr requested a review from thetorpedodog July 27, 2023 15:08
thetorpedodog
thetorpedodog approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@thetorpedodog thetorpedodog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One recommendation but otherwise this looks great.

python-spec/src/somacore/query/query.py Show resolved Hide resolved
@ebezzi ebezzi merged commit 53a772e into main Jul 27, 2023
@ebezzi ebezzi deleted the ebezzi/add-parameters-to-experimentaxis-query branch July 27, 2023 18:48
@johnkerl johnkerl mentioned this pull request Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetorpedodog thetorpedodog thetorpedodog approved these changes

@bkmartinjr bkmartinjr bkmartinjr approved these changes

@johnkerl johnkerl johnkerl approved these changes

@pablo-gar pablo-gar Awaiting requested review from pablo-gar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request] ExperimentAxisQuery read methods should expose batch_size and result_order params
5 participants
@ebezzi @johnkerl @bkmartinjr @thetorpedodog @pablo-gar