Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] ExperimentAxisQuery read methods should expose batch_size and result_order params #1527

Closed
1 of 2 tasks
bkmartinjr opened this issue Jul 11, 2023 · 3 comments · Fixed by single-cell-data/SOMA#169 or #1553
Assignees

Comments

@bkmartinjr
Copy link
Member

bkmartinjr commented Jul 11, 2023

The current read methods (X(), etc) on ExperimentAxisQuery do not accept the common read() arguments which control ordering, etc. This reduces their utility when the user wants (for example) query results on X array to be returned in row-order.

Asks for ExperimentAxisQuery.X, .var and .obs: add at least add result_order and batch_size arguments, but ideally also partitions and platform_config

This is a low-effort change that would greatly increase the query utility.

Edit by @pablo-gar

  • Python API exposes result_order and batch_size
  • R API exposes result_order
@pablo-gar
Copy link
Member

@johnkerl let's consider this for our next sprint.

@ayushnoori
Copy link

Thanks for the feature request, @bkmartinjr!

@pablo-gar
Copy link
Member

Re opening because we still need an R implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment