Revert "in schema, changed fields marked as numbers to singer.decimal… #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 11, 2021 15:57
dmosorast
approved these changes
Mar 11, 2021
tmck-code
pushed a commit
to lexerdev/tap-shopify
that referenced
this pull request
Feb 3, 2022
singer-io#88) * Revert "in schema, changed fields marked as numbers to singer.decimals (singer-io#86)" This reverts commit 5445f6f. * added singer.decimal only for number types that had multipleOf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This reverts commit 5445f6f and then adds back singer.decimal only for schema fields that had a multipleOf property.
QA steps
Risks
low
Rollback steps