in schema, changed fields marked as numbers to singer.decimals (singe…

…r-io#86) * in schema, changed fields marked as numbers to singer.decimals * added string entry * added json validator * modified json validator circle statement
lexerdev · Mar 11, 2021 · 5445f6f · 5445f6f
1 parent c7579c5
commit 5445f6f
Show file tree

Hide file tree

Showing 7 changed files with 117 additions and 93 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -20,6 +20,11 @@ jobs:
           command: |
             source /usr/local/share/virtualenvs/tap-shopify/bin/activate
             make test
+      - run:
+          name: 'JSON Validator'
+          command: |
+            source /usr/local/share/virtualenvs/tap-tester/bin/activate
+            stitch-validate-json /usr/local/share/virtualenvs/tap-shopify/lib/python3.5/site-packages/tap_shopify/schemas/*.json
       - add_ssh_keys
       - run:
           name: 'Integration Tests'

diff --git a/tap_shopify/schemas/abandoned_checkouts.json b/tap_shopify/schemas/abandoned_checkouts.json
@@ -66,8 +66,9 @@
         "latitude": {
           "type": [
             "null",
-            "number"
-          ]
+            "string"
+          ],
+          "format": "singer.decimal"
         },
         "zip": {
           "type": [
@@ -126,8 +127,9 @@
         "longitude": {
           "type": [
             "null",
-            "number"
-          ]
+            "string"
+          ],
+          "format": "singer.decimal"
         }
       }
     },
@@ -157,9 +159,9 @@
           "amount": {
             "type": [
               "null",
-              "number"
+              "string"
             ],
-            "multipleOf": 1e-10
+            "format": "singer.decimal"
           },
           "code": {
             "type": [
@@ -220,9 +222,9 @@
     "total_line_items_price": {
       "type": [
         "null",
-        "number"
+        "string"
       ],
-      "multipleOf": 1e-10
+      "format": "singer.decimal"
     },
     "closed_at": {
       "type": [
@@ -264,16 +266,16 @@
     "total_tax": {
       "type": [
         "null",
-        "number"
+        "string"
       ],
-      "multipleOf": 1e-10
+      "format": "singer.decimal"
     },
     "subtotal_price": {
       "type": [
         "null",
-        "number"
+        "string"
       ],
-      "multipleOf": 1e-10
+      "format": "singer.decimal"
     },
     "line_items": {
       "$ref": "definitions.json#/line_items"
@@ -287,9 +289,9 @@
     "total_discounts": {
       "type": [
         "null",
-        "number"
+        "string"
       ],
-      "multipleOf": 1e-10
+      "format": "singer.decimal"
     },
     "note": {
       "type": [
@@ -349,9 +351,9 @@
           "price": {
             "type": [
               "null",
-              "number"
+              "string"
             ],
-            "multipleOf": 1e-10
+            "format": "singer.decimal"
           },
           "requested_fulfillment_service_id": {
             "type": [
@@ -446,8 +448,9 @@
         "latitude": {
           "type": [
             "null",
-            "number"
-          ]
+            "string"
+          ],
+          "format": "singer.decimal"
         },
         "zip": {
           "type": [
@@ -506,8 +509,9 @@
         "longitude": {
           "type": [
             "null",
-            "number"
-          ]
+            "string"
+          ],
+          "format": "singer.decimal"
         }
       }
     },
@@ -529,9 +533,9 @@
     "total_price": {
       "type": [
         "null",
-        "number"
+        "string"
       ],
-      "multipleOf": 1e-10
+      "format": "singer.decimal"
     },
     "cart_token": {
       "type": [

diff --git a/tap_shopify/schemas/definitions.json b/tap_shopify/schemas/definitions.json
@@ -11,9 +11,9 @@
         "tax_amount": {
           "type": [
             "null",
-            "number"
+            "string"
           ],
-          "multipleOf": 1e-10
+          "format": "singer.decimal"
         },
         "refund_id": {
           "type": [
@@ -24,9 +24,9 @@
         "amount": {
           "type": [
             "null",
-            "number"
+            "string"
           ],
-          "multipleOf": 1e-10
+          "format": "singer.decimal"
         },
         "kind": {
           "type": [
@@ -593,8 +593,9 @@
             "amount": {
               "type": [
                 "null",
-                "number"
-              ]
+                "string"
+              ],
+              "format": "singer.decimal"
             }
           },
           "type": [
@@ -616,8 +617,9 @@
       "pre_tax_price": {
         "type": [
           "null",
-          "number"
-        ]
+          "string"
+        ],
+        "format": "singer.decimal"
       },
       "sku": {
         "type": [
@@ -634,9 +636,9 @@
       "total_discount": {
         "type": [
           "null",
-          "number"
+          "string"
         ],
-        "multipleOf": 1e-10
+        "format": "singer.decimal"
       },
       "name": {
         "type": [
@@ -680,9 +682,9 @@
       "price": {
         "type": [
           "null",
-          "number"
+          "string"
         ],
-        "multipleOf": 1e-10
+        "format": "singer.decimal"
       },
       "requires_shipping": {
         "type": [
@@ -828,9 +830,9 @@
         "price": {
           "type": [
             "null",
-            "number"
+            "string"
           ],
-          "multipleOf": 1e-10
+          "format": "singer.decimal"
         },
         "title": {
           "type": [
@@ -841,9 +843,9 @@
         "rate": {
           "type": [
             "null",
-            "number"
+            "string"
           ],
-          "multipleOf": 1e-10
+          "format": "singer.decimal"
         },
         "compare_at": {
           "type": [

diff --git a/tap_shopify/schemas/order_refunds.json b/tap_shopify/schemas/order_refunds.json
@@ -168,8 +168,9 @@
           "total_tax": {
             "type": [
               "null",
-              "number"
-            ]
+              "string"
+            ],
+            "format": "singer.decimal"
           },
           "quantity": {
             "type": [
@@ -267,8 +268,9 @@
                     "rate": {
                       "type": [
                         "null",
-                        "number"
-                      ]
+                        "string"
+                      ],
+                      "format": "singer.decimal"
                     }
                   },
                   "type": [
@@ -650,8 +652,9 @@
           "subtotal": {
             "type": [
               "null",
-              "number"
-            ]
+              "string"
+            ],
+            "format": "singer.decimal"
           },
           "restock_type": {
             "type": [