TDL-15566: Data loss of child streams #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbshah1212
approved these changes
Oct 13, 2021
tap_pendo/streams.py
Outdated
| @@ -406,7 +406,9 @@ def sync_substream(self, state, parent, sub_stream, parent_response): | |||
| integer_datetime_fmt= | |||
| "unix-milliseconds-integer-datetime-parsing" | |||
| ) as transformer: | |||
| stream_events = sub_stream.sync(state, new_bookmark, | |||
| # bug fix for syncing child streams from start date or | |||
There was a problem hiding this comment.
@savan-chovatiya Instead of writing 'bug fix', you can update the comment to say:
"syncing child streams from start date or state file date"
| stream_events = sub_stream.sync(state, new_bookmark, | ||
| # bug fix for syncing child streams from start date or | ||
| # state file date and not newly updated bookmark | ||
| stream_events = sub_stream.sync(state, bookmark_dttm, |
There was a problem hiding this comment.
@savan-chovatiya Can you please add unit test cases for this code change
| # using "start_date" that is passed and not using the bookmark | ||
| # value stored in the state file, as it will be updated after | ||
| # every sync of child stream for parent stream | ||
| abs_start, abs_end = get_absolute_start_end_time(start_date) |
There was a problem hiding this comment.
@savan-chovatiya What if I run the sync again once all the child streams and parent streams are synced?
Will it still try collecting the data from the "start-date" in the second sync?
There was a problem hiding this comment.
No, it will start collecting from the bookmark present in the state file, here the start_date is just a variable.
karanpanchal-crest
approved these changes
Oct 25, 2021
KrisPersonal
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-15566: Data loss of child streams
new_bookmarkwithbookmark_dttmfor syncing child stream records from the start date rather than the updated bookmark from the previous sync.Manual QA steps
Risks
Rollback steps