TDL-15336: Check best practices #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbshah1212
reviewed
Sep 29, 2021
tap_pendo/streams.py
Outdated
| @@ -406,7 +406,9 @@ def sync_substream(self, state, parent, sub_stream, parent_response): | |||
| integer_datetime_fmt= | |||
| "unix-milliseconds-integer-datetime-parsing" | |||
| ) as transformer: | |||
| stream_events = sub_stream.sync(state, new_bookmark, | |||
There was a problem hiding this comment.
Can you please create a new card for this and change this code in a different branch with possible unittest/ integration tests.
There was a problem hiding this comment.
Raise PR #57 for this bug.
dbshah1212
approved these changes
Sep 29, 2021
karanpanchal-crest
approved these changes
Oct 7, 2021
KrisPersonal
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-15336: Check best practices
devandtestManual QA steps
Risks
Rollback steps