Fix cannot open url contains | on windows

[baoti]

• If contains space, DO NOT escape;
• otherwise, DO escape.
• No matter target is URL, or file path.
• Escape Character: & \ < > ^ |

Detail in #74 (comment).

[sindresorhus]

Can you link to some documentation about this?

[baoti]

Oh, I found https://ss64.com/nt/syntax-esc.html, look at the Escape Character section.

Escape Character
  ^  Escape character.
Adding the escape character before a command symbol allows it to be treated as ordinary text. 
When piping or redirecting any of these charcters you should prefix with the escape character: & \ < > ^ |

 e.g.  ^\  ^&  ^|  ^>  ^<  ^^ 

[baoti]

@sindresorhus Do you want me replace all those characters?

\
&
|
>
<
^

[sindresorhus]

What do you think about #74 (comment) ? If it works, it would be better.

[baoti]

OK, I‘d like to work on it.

[baoti]

@sindresorhus I add many test results in #74 (comment).

I think these test cases is useful to position the issue #74.

[sindresorhus]

@baoti Still interested in handling #98 (comment)?

[baoti]

@sindresorhus As #74 (comment) said, wrapping it in double quotes doesn't help. What do you want handling?

[Cossey]

I think @baoti's approach mentioned here would be the best way forward. What an annoying quirk!

[sindresorhus]

Alright, let's try out this then:

If contains space, DO NOT escape;
otherwise, DO escape.

[sindresorhus]

Suggested change

	if (target.indexOf(' ') === -1) {
	if (!target.includes(' ')) {

[sindresorhus]

Can you also link to #74 (comment) in a code comment to clarify what it does and why.

[sindresorhus]

@baoti Can you fix the merge conflict?

[baoti]

@sindresorhus I got the reason for doing not escape which contains space char. The argument would be wrapped in double quotes. See source for detail.

We can pass childProcessOptions.windowsVerbatimArguments = true to disable it, and always escape target by double quotes.

[sindresorhus]

Good find. Let’s do that then.