Handle URL and paths escaping in Windows

[herberttn]

This fixes an old problem that has been widely reported but haven't had a simple and concrete solution yet. This is my attempt on making it happen 🙃

To sum up the problem: on windows, ampersand (&) characters were being escaped with caret (^) characters due to windows's cmd interpreting them as a command would break (as in command not found) or would forward a partial argument only (as in URLs with query arguments that contain spaces).

The solution: JavaScript's standard encodeURI function would solve the problem for URLs, but not for file paths (especially on windows). So we leverage the fact that window's cmd interprets a double-quoted argument as a plain text argument just by quoting it (like Node already does). For that to be consistent we need to disable Node's default quoting and escaping behavior (which is conditional) with its own windowsVerbatimArguments flag, and do it ourselves.

Tested in Windows with both Google Chrome and Internet Explorer, using query strings, spaces, pipes, fragments and multiple combinations of all of them.

• Fixes Strips querystring from URL if it precedes with # in Windows 10 - Chrome #17: URL fragments
• Fixes Incorrectly add "^" before "&" in url query strings #44: URL query strings (ampersand escaping)
• Fixes Bug opening file path html file with query param #55: URL query strings with local HTML files (ampersand escaping)
• Fixes on windows, can't opn a directory with an ampersand #77: File system path (ampersand escaping)
• Fixes Open local HTML file URL with a query string #101: URL query strings with local HTML files (ampersand escaping)
• Fixes Use the childProcess.spawn shell option on Windows and fix the quote issue #115: Shell option is not needed since windowsVerbatimArguments is now used explicitly
• Resolves Add an option to allow disabling ampersand escaping #74: File system path (ampersand escaping)
• Resolves Fix cannot open url contains | on windows #98: URL with pipe characters

---

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

• #115: Use the childProcess.spawn shell option on Windows and fix the quote issue
• #77: on windows, can't opn a directory with an ampersand

---

IssueHunt has been backed by the following sponsors. Become a sponsor

[herberttn]

@sindresorhus Need me to do something else? Can we get a new version with this fix?

[sindresorhus]

Sorry for the slow response. I have a lot to catch up on after the summer.

[Stanzilla]

Does this also fix the problem in #98?

[herberttn]

Does this also fix the problem in #98?

Hello @Stanzilla, yes it does!
This one fixes/closes all of the issues/pulls listed in the description!

Since I'm here: Hey @sindresorhus, when you have some spare time, this is ready for another review ;)

[sindresorhus]

@herberttn Thanks for your awesome work on this 🙌

[sindresorhus]

https://github.com/sindresorhus/open/releases/tag/v7.0.0

[herberttn]

@herberttn Thanks for your awesome work on this 🙌

🎉

[baoti]

Maybe need some test for urls contains '%' (e.g. https://cn.bing.com/search?q=%2520 https://cn.bing.com/search?q=%E5%A5%BD). I think encodeURI will break url which is already url encoded.