Update cross character

[gibson042]

Fixes #92

[ehmicky]

The following test needs to be fixed as well.
I am surprised why this is not actually failing in CI? 🤔

figures/test.js

Lines 17 to 18 in 62b5c69

	t.is(replaceSymbols('✔ ✖\n★ ◼'), result('✔ ✖\n★ ◼', '√ ×\n✶ ■'));
	t.is(replaceSymbols('✔ ✖ ★ ◼'), result('✔ ✖ ★ ◼', '√ × ✶ ■'));

[gibson042]

Thanks, updated.

[ehmicky]

Thanks a lot @gibson042!

[ehmicky]

Looks good! Just one small suggestion.

[ehmicky]

This looks good!
What do you think @sindresorhus?

[gibson042]

This is probably a minor point, but U+2716 HEAVY MULTIPLICATION X "✖︎" and U+2714 HEAVY CHECK MARK "✔︎" are both technically emoji while U+2718 HEAVY BALLOT X "✘︎" is not. Another possible alternative to the latter would be U+274C CROSS MARK "❌︎", but that one has the further complication of having Emoji_Presentation (e.g., its default form when not forced into text as I have done in the preceding clause is "❌"). That characteristic is also true of U+2705 WHITE HEAVY CHECK MARK "✅︎"/"✅", but outlined glyphs don't really work in a terminal context.

All told, I'm pretty confident that U+2718 HEAVY BALLOT X "✘︎" is the right choice, but it is still worth providing the context. And if the mismatch is a problem, it is possible to suffix the emoji characters with U+FE0E VARIATION SELECTOR-15 to force text presentation as I have done here.

[ehmicky]

Thanks for the added explanation. Based on this, U+2718 on its own (what this PR does) makes even more sense.