-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main cross
character is incorrect
#92
Comments
Hi @gibson042, I have tried to display
From a style standpoint, ti seems to me that That being said, could you please add some additional description as to what specifically makes Also, if you find some time, could you open a similar issue and/or PR with https://github.com/sindresorhus/log-symbols to keep those in sync? Thanks! |
Sure, I'm primarily concerned about proper semantics and the corresponding consequences upon vision-impaired users. For example, screen readers are notoriously bad at symbols, and for example VoiceOver reads U+2716 HEAVY MULTIPLICATION X "✖︎" as "multiplication symbol", which is appropriate for that software because the character is in fact a multiplication symbol. But that has no obvious connection to negative status such as a test failure, and the fact that they are visually similar is insufficient reason to consider them as interchangeable. |
This makes sense, thanks for explaining! 👍 |
(discovered while working on ava test result accessibility: avajs/ava#3082 )
The main
cross
character is U+2716 HEAVY MULTIPLICATION X "✖︎", but for accessibility (and proper contrast withtick
U+2714 HEAVY CHECK MARK "✔︎") it should instead be U+2718 HEAVY BALLOT X "✘︎".The text was updated successfully, but these errors were encountered: