verify_token always return a dict and not raise an HTTPError #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix #62 |
|
I need this one merged for the async http request. |
|
@kitchoi still broken. |
|
@stefanoborini just pushed a fix as you commented :) |
Current coverage is 79.09%@@ master #77 diff @@
==========================================
Files 27 27
Lines 913 904 -9
Methods 0 0
Messages 0 0
Branches 84 83 -1
==========================================
- Hits 722 715 -7
+ Misses 164 163 -1
+ Partials 27 26 -1
|
|
@kitchoi good for me. please merge when green. I'll take care of the conflicts with the other branch (I still have some work to do there) |
|
Thanks @stefanoborini |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verify_tokenwould return a dict containing the user data from jupyterhub and the remoteappmanager would further verify the data. The dictionary is empty if authentication/authorisation fails.HTTPError is not raised, but in the future we may want to introduce the HTTPError back again for better error message on the user's end.