Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify_token should return True or False, not raise HTTPError #62

Closed
stefanoborini opened this issue Jul 7, 2016 · 1 comment
Closed
Assignees
Milestone

Comments

@stefanoborini
Copy link
Contributor

The signature of Hub.verify_token is a bit inconsistent. I suspect we use it for returning a reason for the failure, but it just looks weird, it might need some thought.

@itziakos itziakos added this to the 0.4.0 milestone Jul 8, 2016
@kitchoi kitchoi self-assigned this Jul 8, 2016
@kitchoi
Copy link
Contributor

kitchoi commented Jul 8, 2016

In jupyterhub, it is okay to raise HTTPError because their BaseHandler has overwritten the write_error and render an error page with the HTTPError messages. We could do the same with write_error.
As for successful request, it should return the json data instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants