Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename --limit to --config, add --help-config #274

Closed
simonw opened this issue May 19, 2018 · 2 comments
Closed

Rename --limit to --config, add --help-config #274

simonw opened this issue May 19, 2018 · 2 comments

Comments

@simonw
Copy link
Owner

simonw commented May 19, 2018 •
edited
Loading

#270 introduced --limit but on further thought it should be called --config instead.

--page_size should becomes --config default_page_size:1000

Add --help-config to show full help showing all config settings.
@simonw
Copy link
Owner Author

simonw commented May 19, 2018 •
edited
Loading

Could also support these as optional environment variables - DATASETTE_NAMEOFSETTING

@simonw simonw mentioned this issue May 20, 2018
Closed
@simonw simonw changed the title Rename --limit to --config, support in metadata.json too Rename --limit to --config, support strings, integers and booleans May 20, 2018
@simonw simonw changed the title Rename --limit to --config, support strings, integers and booleans Rename --limit to --config, add --help-config May 20, 2018
@simonw simonw closed this as completed in f6183ff May 20, 2018
simonw pushed a commit to simonw/fivethirtyeight-datasette that referenced this issue May 20, 2018
Use new --config option
31fc66a 
From simonw/datasette#274
@simonw
Copy link
Owner Author

simonw commented May 20, 2018

http://datasette.readthedocs.io/en/latest/config.html

@simonw simonw mentioned this issue May 24, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw