Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"config" section in metadata.json (root, database and table level) #275

Closed
simonw opened this issue May 20, 2018 · 3 comments
Closed

"config" section in metadata.json (root, database and table level) #275

simonw opened this issue May 20, 2018 · 3 comments

Comments

@simonw
Copy link
Owner

simonw commented May 20, 2018

Split off from #274

Metadata should an optional "config" section at root, table or database level.

The TableView and RowView and DatabaseView and BaseView classes could all have a .config("key") method which knows how to resolve the hierarchy of configs.

This will allow individual tables (or databases) to set their own config settings for things like sql_time_limit_ms

@simonw
Copy link
Owner Author

simonw commented May 24, 2018

So the lookup priority order should be:

  • table level in metadata
  • database level in metadata
  • root level in metadata
  • --config options passed to datasette serve
  • DATASETTE_X environment variables

@simonw
Copy link
Owner Author

simonw commented May 24, 2018

It feels slightly weird continuing to call it metadata.json as it starts to grow support for config options (which already started with the units and facets keys) but I can live with that.

@simonw simonw added the feature label May 28, 2018
@simonw simonw added this to the Next release milestone Jul 24, 2018
@simonw simonw removed this from the Next release milestone May 13, 2019
@simonw
Copy link
Owner Author

simonw commented Aug 23, 2023

This is obsoleted by the work happening here:

@simonw simonw closed this as completed Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant