Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace http_request function with httpx #68

Closed
simonw opened this issue Jan 23, 2021 · 1 comment
Closed

Replace http_request function with httpx #68

simonw opened this issue Jan 23, 2021 · 1 comment
Labels
enhancement New feature or request
Milestone
1.0

Comments

@simonw
Copy link
Owner

simonw commented Jan 23, 2021

I wrote my own http_request() function because httpx didn't support Python 3.5. Datasette has dropped support for Python 3.5 and embraced httpx internally now.

datasette-auth-github/datasette_auth_github/utils.py

Line 6 in 53277f1

async def http_request(url, body=None, headers=None):

@simonw simonw added the enhancement New feature or request label Jan 23, 2021
@simonw simonw added this to the 1.0 milestone Jan 23, 2021
@simonw
Copy link
Owner Author

simonw commented Jan 23, 2021

I also get to ditch my complex custom stubbing code:

datasette-auth-github/tests/test_datasette_auth_github.py

Line 9 in 53277f1

async def stub_http_request(url, body=None, headers=None):

@simonw simonw closed this as completed in 31405aa Jan 23, 2021
simonw added a commit that referenced this issue Jan 24, 2021
@simonw
Release 0.13
bd33ed0 
Refs #36, #62, #63, #64, #65, #66, #67, #68, #69, #70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@simonw