Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split off asgi-auth-github #63

Closed
simonw opened this issue Jun 10, 2020 · 2 comments
Closed

Split off asgi-auth-github #63

simonw opened this issue Jun 10, 2020 · 2 comments

Comments

@simonw
Copy link
Owner

simonw commented Jun 10, 2020

I'm going to fork the existing codebase as asgi-auth-github and ship 1.0 as supporting Datasette only.

Originally posted by @simonw in #62 (comment)
@simonw
Copy link
Owner Author

simonw commented Jun 10, 2020

After Datasette 0.44 it's just too complicated to maintain one project that works both as standalone ASGI middleware AND as a Datasette authentication plugin.

So I'm going to split the project in two.

simonw added a commit that referenced this issue Jun 10, 2020
@simonw
Split off as new asgi-auth-github package
8181dad 
Refs #63
@simonw
Copy link
Owner Author

simonw commented Jun 10, 2020

Done: https://github.com/simonw/asgi-auth-github and https://pypi.org/project/asgi-auth-github/

@simonw simonw closed this as completed Jun 10, 2020
simonw added a commit to simonw/starlette that referenced this issue Jun 10, 2020
@simonw
datasette-auth-github is now asgi-auth-github
f127e91 
simonw/datasette-auth-github#63
@simonw simonw mentioned this issue Jun 10, 2020
Merged
simonw added a commit that referenced this issue Jan 24, 2021
@simonw
Release 0.13
bd33ed0 
Refs #36, #62, #63, #64, #65, #66, #67, #68, #69, #70
Kludex added a commit to encode/starlette that referenced this issue Sep 18, 2021
@simonw @florimondmanca
@erewok @Kludex
datasette-auth-github is now asgi-auth-github (#967)
04242e3 
simonw/datasette-auth-github#63

Co-authored-by: Florimond Manca <[email protected]>
Co-authored-by: Erik <[email protected]>
Co-authored-by: Marcelo Trylesinski <[email protected]>
hidraco added a commit to hidraco/starlette that referenced this issue Apr 21, 2022
@hidraco @florimondmanca
@erewok @Kludex
datasette-auth-github is now asgi-auth-github (#967)
815cf7d 
simonw/datasette-auth-github#63

Co-authored-by: Florimond Manca <[email protected]>
Co-authored-by: Erik <[email protected]>
Co-authored-by: Marcelo Trylesinski <[email protected]>
dudleyhunt86 added a commit to dudleyhunt86/starlette-develop-with-python that referenced this issue Oct 7, 2022
@dudleyhunt86 @florimondmanca
@erewok @Kludex
datasette-auth-github is now asgi-auth-github (#967)
35ebf67 
simonw/datasette-auth-github#63

Co-authored-by: Florimond Manca <[email protected]>
Co-authored-by: Erik <[email protected]>
Co-authored-by: Marcelo Trylesinski <[email protected]>
azurelotus0926 added a commit to azurelotus0926/starlette that referenced this issue Jun 27, 2024
@azurelotus0926 @florimondmanca
@erewok @Kludex
datasette-auth-github is now asgi-auth-github (#967)
06e2da5 
simonw/datasette-auth-github#63

Co-authored-by: Florimond Manca <[email protected]>
Co-authored-by: Erik <[email protected]>
Co-authored-by: Marcelo Trylesinski <[email protected]>
github-actions bot pushed a commit to Kludex/jik that referenced this issue Aug 16, 2024
@simonw @florimondmanca
@erewok @Kludex
datasette-auth-github is now asgi-auth-github (#967)
91fd263 
simonw/datasette-auth-github#63

Co-authored-by: Florimond Manca <[email protected]>
Co-authored-by: Erik <[email protected]>
Co-authored-by: Marcelo Trylesinski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw