Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It seems undici should be in dependencies instead of devDependencies #69

Closed
zloirock opened this issue Mar 9, 2024 · 3 comments
Closed

It seems undici should be in dependencies instead of devDependencies #69

zloirock opened this issue Mar 9, 2024 · 3 comments

Comments

@zloirock
Copy link

zloirock commented Mar 9, 2024

image
zloirock added a commit to zloirock/core-js that referenced this issue Mar 9, 2024
@zloirock
pin updates
26fb10a 
silverwind/updates#69
@silverwind
Copy link
Owner

silverwind commented Mar 9, 2024 •
edited
Loading

Ah, you are right, fetch-enhanced has it as peerDependency just to access the ProxyAgent that Node does not export yet, so it's meant to be carried as dependency. I'll move it.

silverwind added a commit that referenced this issue Mar 9, 2024
@silverwind
15.3.1
7adede6 
* Revert "switch to undici" - fixes #69 (silverwind)
@silverwind
Copy link
Owner

Fixed by reverting to node-fetch. undici is a too big of dependency to carry right now.

@silverwind
Copy link
Owner

Followup issue: #70

zloirock added a commit to zloirock/core-js that referenced this issue Mar 9, 2024
@zloirock
update dependencies, unpin updates
f3a3911 
silverwind/updates#69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@silverwind @zloirock