Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Node's built-in fetch #70

Closed
silverwind opened this issue Mar 9, 2024 · 2 comments
Closed

Use Node's built-in fetch #70

silverwind opened this issue Mar 9, 2024 · 2 comments

Comments

@silverwind
Copy link
Owner

Options are:

I think I will most likely go with option 3 as I personally have no need for proxy support on the machines where I use updates.

@silverwind
Copy link
Owner Author

Upon further reconsideration, proxy support is still somewhat important for CI environments and such, so I will keep it at least until Node provides a way to have proxy support without a explicit undici dependency.

@silverwind
Copy link
Owner Author

silverwind commented Mar 16, 2024

Fixed with e9327ab. Node will loose proxy support on next release until nodejs/undici#1650 is fixed. Bun and Deno can be used as alternatives with proxy support.

silverwind added a commit that referenced this issue Mar 16, 2024
* update note (silverwind)
* add note regarding undici (silverwind)
* update deps (silverwind)
* add bun to ci (silverwind)
* use native fetch everywhere (silverwind)
* bump actions (silverwind)
* add comment (silverwind)
* only import fetch-enhanced when needed (silverwind)
* only import node-fetch when needed (silverwind)
* rename bin dir to dist (silverwind)
* Revert "always use the built-in fetch - fixes #70" (silverwind)
* always use the built-in fetch - fixes #70 (silverwind)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant