API Update deprecations #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
GuySartorelli
requested changes
Nov 20, 2022
| * @return Library[] | ||
| */ | ||
| protected function getAllModules() | ||
| { | ||
| Deprecation::notice('1.3.0', 'Use getAllLibraries() instead'); |
There was a problem hiding this comment.
Framework isn't a dependency of this library. We could use raw PHP deprecation notice I guess?
|
Can't use the Deprecation class here as this is used by composer. I don't want to emit deprecation warnings here as there is no way to toggle them off. I think we're best to just leave things as they are. We can still remove the deprecated code in any new major versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10544