Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardise deprecations in CMS 4 for kitchen-sink #10544

Closed
3 tasks
emteknetnz opened this issue Oct 12, 2022 · 1 comment
Closed
3 tasks

Standardise deprecations in CMS 4 for kitchen-sink #10544

emteknetnz opened this issue Oct 12, 2022 · 1 comment
Assignees
@GuySartorelli
Labels
affects/v4 type/enhancement

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Oct 12, 2022 •
edited
Loading

recipe/kitchen-sink version of #10500

Do the following for all non-silverstripe/installer modules contained in silverstripe/recipe-kitchen-sink

Acceptance criteria

  • Code with a @deprecated annotation throw a Deprecation::notice()
  • Code throwing a Deprecation::notice() is annotated with a @deprecated
  • Standardize the @deprecated annotation

Implementation lessons from 10500

PRs
@emteknetnz emteknetnz self-assigned this Oct 12, 2022
This was referenced Nov 15, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
@emteknetnz emteknetnz removed their assignment Nov 16, 2022
@GuySartorelli GuySartorelli self-assigned this Nov 20, 2022
@GuySartorelli
Copy link
Member

All PRs merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuySartorelli GuySartorelli

Labels
affects/v4 type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli