Standarise deprecations in CMS4 for framework

[maxime-rainville]

We need to review and normalise our deprecation notice in CMS4 to facilitate upgrades

Acceptance criteria

• Code with a @deprecated annotation throw a Deprecation::notice()
• Code throwing a Deprecation::notice() is annotated with a @deprecated
• Unit test for deprecated code is not run when deprecation notices are enabled.
• Our CI is updated to have a build that runs with deprecation warning enabled.
• Normalise the @deprecated annotation ... within reason.

Note

• This card is only for the core modules See update below
• We will most likely ended up deprecating more code after this card is merged.
• A decision needs to be made about how to handle deprecating whole classes - possibly a constructor will need to be added, and the deprecation notice added via that constructor. -> update - handle via Deprecation::SCOPE_CLASS in __construct().

Update

• I've split this issue so that this one is for framework only - other core modules will handled on this issue Standardise deprecations in CMS4 for other core modules #10531

PRs

• FIX Prevent infinite loops in Deprecation::notice() #10530
• API Update deprecations #10525

[GuySartorelli]

@emteknetnz The acceptance criteria in this card imply changes will need to be made to the CI - do those changes still need to be made?

[GuySartorelli]

PRs are merged and ACs have all been met or spun off into separate cards. Closing.