API Update deprecations

[emteknetnz]

Blocked by #10530

Issue #10500

There are 3 commits in this (will be only 2 after another PR is merged):

• the first one is the commit in FIX Prevent infinite loops in Deprecation::notice() #10530
• the second one is manual processing of SapphireTest.php and FunctionalTest.php
• the third on is automatic code-writing using https://github.com/emteknetnz/silverstripe-deprecator

[GuySartorelli]

Why did you do #10530 as a separate PR? And why then include it in this PR? That's confusing.

[GuySartorelli]

There's at least one non-standard deprecation that hasn't been touched: Module::getCIConfig() has the wrong version number, is missing a deprecation message in the phpdoc, and has an unhelpful message in the notice.

There are also bound to be cases which I missed where the phpdoc is missing the deprecation message. It needs to be in the notice and in the phpdoc.

I'm guessing based on what I have seen that you just ran some code writer over this and didn't look too closely at the output?

[GuySartorelli]

There are some cases where the "Use [something else] instead" message is missing the word "instead" - but that doesn't materially change the message so asking you to change that would be nitpicking at this point - I'm just pointing it out to satisfy my brain but no change is required for that.