Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP PHP Support in CMS5 #122

Merged
merged 2 commits into from
Jan 17, 2023
Merged

DEP PHP Support in CMS5 #122

merged 2 commits into from
Jan 17, 2023

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova mentioned this pull request Dec 13, 2022
Closed
3 tasks
@sabina-talipova
Copy link
Contributor Author

Requires

@sabina-talipova sabina-talipova force-pushed the pulls/5/upgrade-cms5 branch 3 times, most recently from 04733db to 2295eb7 Compare January 17, 2023 02:04
emteknetnz
emteknetnz requested changes Jan 17, 2023
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails with "Registration failed: decodeNoPadding() doesn't tolerate padding" when I manually test with a yubikey

Exception comes from vendor/paragonie/contant_time_encoding/src/Base32.php

@GuySartorelli
Copy link
Member

GuySartorelli commented Jan 17, 2023 •
edited
Loading

That class has decodeNoPadding() and decode() (the latter of which does tolerate padding).
It seems like it's common to use str_pad() or similar to add padding to encoded strings... if you can include the full stack trace there I might be able to see where that padding's being added and whether we can either not include the padding, or use the other decode method.

Relevant: https://github.com/paragonie/constant_time_encoding/releases/tag/v2.6.0

@emteknetnz emteknetnz mentioned this pull request Jan 17, 2023
Closed
1 task
emteknetnz
emteknetnz approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll merge as is and fix issue post-beta - #124

@emteknetnz emteknetnz merged commit 7b28403 into silverstripe:5 Jan 17, 2023
@emteknetnz emteknetnz deleted the pulls/5/upgrade-cms5 branch January 17, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sabina-talipova @GuySartorelli @emteknetnz