Skip to content

Commit

Permalink
DEP PHP Support in CMS5
Browse files Browse the repository at this point in the history
  • Loading branch information
Sabina Talipova committed Jan 17, 2023
1 parent 92ec2e8 commit 2295eb7
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 10 deletions.
8 changes: 4 additions & 4 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
],
"license": "BSD-3-Clause",
"require": {
"php": "^7.4 || ^8.0",
"php": "^8.1",
"ext-bcmath": "*",
"silverstripe/framework": "^4.12",
"silverstripe/mfa": "^4.6",
"web-auth/webauthn-lib": "^3.3",
"silverstripe/framework": "^5",
"silverstripe/mfa": "^5",
"web-auth/webauthn-lib": "^4.4",
"guzzlehttp/psr7": "^2"
},
"require-dev": {
Expand Down
4 changes: 2 additions & 2 deletions src/BaseHandlerTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

use CBOR\Decoder;
use CBOR\OtherObject\OtherObjectManager;
use CBOR\Tag\TagObjectManager;
use CBOR\Tag\TagManager;
use Webauthn\AttestationStatement\AttestationObjectLoader;
use Webauthn\AttestationStatement\AttestationStatementSupportManager;
use Webauthn\AttestationStatement\FidoU2FAttestationStatementSupport;
Expand All @@ -33,7 +33,7 @@ protected function getDecoder(): Decoder
{
return Deprecation::withNoReplacement(function () {
Deprecation::notice('4.5.0', 'Will be removed without equivalent functionality to replace it');
return new Decoder(new TagObjectManager(), new OtherObjectManager());
return new Decoder(new TagManager(), new OtherObjectManager());
});
}

Expand Down
7 changes: 3 additions & 4 deletions src/RegisterHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,7 @@ protected function getCredentialCreationOptions(
*/
protected function getAuthenticatorSelectionCriteria(): AuthenticatorSelectionCriteria
{
return new AuthenticatorSelectionCriteria(
(string) $this->config()->get('authenticator_attachment')
);
}
return AuthenticatorSelectionCriteria::create()
->setAuthenticatorAttachment((string) $this->config()->get('authenticator_attachment'));
}
}

0 comments on commit 2295eb7

Please sign in to comment.