Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Not working previous form step if there is more than one hidden page #1148

Merged
merged 1 commit into from
May 25, 2022
Merged

FIX Not working previous form step if there is more than one hidden page #1148

merged 1 commit into from
May 25, 2022

Conversation

sabina-talipova
Copy link
Contributor

Description

  • The missing argument was provided in the recursive jumpToStep() function call.
  • New Behat tests have been added.

Parent issue

@sabina-talipova sabina-talipova changed the base branch from 5 to 5.12 May 25, 2022 01:13
@GuySartorelli
Copy link
Member

Context: This PR replaces #1147

GuySartorelli
GuySartorelli approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge on green

@sabina-talipova sabina-talipova mentioned this pull request May 25, 2022
Closed
2 tasks
@GuySartorelli GuySartorelli merged commit 52804b0 into silverstripe:5.12 May 25, 2022
@GuySartorelli GuySartorelli deleted the pulls/5.12/bug-previous-form-step branch May 25, 2022 01:58
@GuySartorelli GuySartorelli linked an issue May 25, 2022 that may be closed by this pull request
Bug - Unable to move to previous form step if there is more than one hidden page between current and previous steps #1123
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sabina-talipova @GuySartorelli