Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Not working previous form step if there is more than one hidden page #1147

Closed
wants to merge 1 commit into from
Closed

FIX Not working previous form step if there is more than one hidden page #1147

wants to merge 1 commit into from

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented May 24, 2022 •
edited
Loading

Description

  • The missing argument was provided in the recursive jumpToStep() function call.
  • New Behat tests have been added.

Parent issue

@sabina-talipova sabina-talipova changed the title FIX Add skipping argument and new behat tests FIX Not working previous form step if there is more than one hidden page May 24, 2022
@sabina-talipova sabina-talipova mentioned this pull request May 24, 2022
Closed
2 tasks
GuySartorelli
GuySartorelli requested changes May 24, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works locally, and the test is good.

Please target the 5.12 branch. 5.13 is still in beta, so bug fixes should go to 5.12 for a patch release.

@sabina-talipova sabina-talipova changed the base branch from 5.13 to 5.12 May 24, 2022 23:13
@sabina-talipova sabina-talipova changed the base branch from 5.12 to 5.13 May 24, 2022 23:13
@sabina-talipova sabina-talipova deleted the pulls/5.13/bug-previous-form-step branch May 25, 2022 01:12
@GuySartorelli GuySartorelli mentioned this pull request May 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli