ENH Use HashNameObfuscator in dev environments #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #500
This probably won't resolve the issue, though it does fix up issues where the .graphql-generated folder is created in a
devenvironment, commit to git and then deployed to prod. We don't mention in dev docs that different obfuscation classes are used on different environmentsI think there's near zero value in keeping the class name intact since it's an auto-generated class, and for debugging you can either swap out to another obfuscator (can do this in yml or by setting the DEBUG_SCHEMA env variable), or just search for the type name in file content comments e.g.
// @type:Query.The classname is better being more obfuscated locally for a better IDE experience IMO
Note - obfuscation was only ever intended to help the IDE experience, it's not at attempt at security #369