Skip to content

Commit

Permalink
Merge pull request #506 from creative-commoners/pulls/4/gql-obs
Browse files Browse the repository at this point in the history
  • Loading branch information
michalkleiner authored Nov 11, 2022
2 parents dce7e55 + b47177d commit 1cb2e6c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 12 deletions.
11 changes: 1 addition & 10 deletions _config/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ SilverStripe\Core\Injector\Injector:
storeCreator: '%$SilverStripe\GraphQL\Schema\Interfaces\SchemaStorageCreator'

SilverStripe\GraphQL\Schema\Storage\NameObfuscator:
class: SilverStripe\GraphQL\Schema\Storage\HybridObfuscator
class: SilverStripe\GraphQL\Schema\Storage\HashNameObfuscator

SilverStripe\GraphQL\Schema\Schema:
schemas: []
Expand Down Expand Up @@ -61,12 +61,3 @@ Only:
SilverStripe\Core\Injector\Injector:
SilverStripe\GraphQL\Schema\Storage\NameObfuscator:
class: SilverStripe\GraphQL\Schema\Storage\NaiveNameObfuscator

---
Name: graphqlconfig-live
Except:
environment: dev
---
SilverStripe\Core\Injector\Injector:
SilverStripe\GraphQL\Schema\Storage\NameObfuscator:
class: SilverStripe\GraphQL\Schema\Storage\HashNameObfuscator
2 changes: 1 addition & 1 deletion src/Schema/Storage/HashNameObfuscator.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
namespace SilverStripe\GraphQL\Schema\Storage;

/**
* For the most obscure approach, hash the file names so they're completely undiscoverable.
* For the most obscure approach, hash the file names so they're highly undiscoverable in IDE search
*/
class HashNameObfuscator implements NameObfuscator
{
Expand Down
2 changes: 1 addition & 1 deletion src/Schema/Storage/NameObfuscator.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
namespace SilverStripe\GraphQL\Schema\Storage;

/**
* Defines a service that can obfuscate classnames to make their files less discoverable
* Defines a service that can obfuscate classnames to make their files less discoverable in IDE Search
*/
interface NameObfuscator
{
Expand Down

0 comments on commit 1cb2e6c

Please sign in to comment.