Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Revert "ENH Add Nice to DBField" #11222

Merged
merged 1 commit into from
May 6, 2024
Merged

FIX Revert "ENH Add Nice to DBField" #11222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/ORM/FieldType/DBField.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,14 +516,6 @@ public function CDATA()
return $this->XML();
}

/**
* @return string
*/
public function Nice()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a semver breakage as Nice() isn't defined in parent class ViewableData. At a practical level though this shouldn't matter.

I think this PR should target 5.2 instead since it's fixing a bug introduced in 5.2

Other option is to change this method to return $this->->forTemplate() to match what happens in GridFieldDataColumns, though that seems messy.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind ignore me, not in 5.2 branch

{
return $this->XML();
}

/**
* Returns the value to be set in the database to blank this field.
* Usually it's a choice between null, 0, and ''
Expand Down
Loading