FIX Revert "ENH Add Nice to DBField" #11222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b167f47.
This was referenced May 6, 2024
emteknetnz
requested changes
May 6, 2024
| /** | ||
| * @return string | ||
| */ | ||
| public function Nice() |
There was a problem hiding this comment.
This is a semver breakage as Nice() isn't defined in parent class ViewableData. At a practical level though this shouldn't matter.
I think this PR should target 5.2 instead since it's fixing a bug introduced in 5.2
Other option is to change this method to return $this->->forTemplate() to match what happens in GridFieldDataColumns, though that seems messy.
There was a problem hiding this comment.
Never mind ignore me, not in 5.2 branch
emteknetnz
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit b167f47.
Issues
GridFieldescapes HTML content inappropriately #11191