ENH Use guzzle for oembed #10311
Merged
ENH Use guzzle for oembed #10311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
emteknetnz
force-pushed
the
pulls/4.11/oembed
branch
from
f078ce2 to
d3144b9
Compare
| class: GuzzleHttp\Client | ||
| Embed\Http\Crawler: | ||
| constructor: | ||
| - '%$Psr\Http\Client\ClientInterface.oembed' |
There was a problem hiding this comment.
It's a good idea using Guzzle all the time.
There was a problem hiding this comment.
I'm thinking maybe in some later PR we'll want to define a global HTTP client that people can use for every request. But that's another PR for another day.
emteknetnz
force-pushed
the
pulls/4.11/oembed
branch
from
d3144b9 to
415d940
Compare
emteknetnz
force-pushed
the
pulls/4.11/oembed
branch
from
415d940 to
c72efa0
Compare
GuySartorelli
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #10305
Note: cwp-core 2.10.0 which has the old curl config has already been tagged as part of 4.11.0-beta1 release, so assumption is that we'd release the fix on cwp-core as a patch release 2.10.1. Hence the composer conflict of
"cwp/cwp-core": "<2.10.1"