FIX Update oembed config #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 11, 2022
|
The fact that this is passing in travis when its dependencies aren't merged in yet seems a bit concerning... is there some tests that should be added to test this? |
emteknetnz
force-pushed
the
pulls/2.10/guzzle
branch
from
53f8329 to
5cfe51e
Compare
|
It's hard to test since what the purpose of this is to work on CWP hosting where there are some environment variable set. I've added a unit test to test that framework is configured to create a Guzzle client, so in case we change the client again in the future so the config makes no sense, it should break. Note: unit test needs silverstripe/silverstripe-framework#10311 merged first Update: have tested this works CWP hosting in conjuction with the 2x framework PRs |
GuySartorelli
requested changes
May 12, 2022
emteknetnz
force-pushed
the
pulls/2.10/guzzle
branch
from
5cfe51e to
c6e03df
Compare
emteknetnz
force-pushed
the
pulls/2.10/guzzle
branch
from
c6e03df to
f694530
Compare
GuySartorelli
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10305
Requires silverstripe/silverstripe-framework#10312 to allow multiple backtick values to be set at once
Requires silverstripe/silverstripe-framework#10311 so that guzzle is being used
Release
2.10.12.11.0-beta1 when merged