Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW Get the version for an individual module #10235

Merged
merged 1 commit into from
Mar 9, 2022
Merged

NEW Get the version for an individual module #10235

merged 1 commit into from
Mar 9, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Feb 16, 2022 •
edited
Loading

This was referenced Feb 16, 2022
Closed
Merged
@emteknetnz emteknetnz force-pushed the pulls/4/meta-generator branch 4 times, most recently from 92cdc6a to 7272aa3 Compare February 16, 2022 05:59
@emteknetnz emteknetnz force-pushed the pulls/4/meta-generator branch 2 times, most recently from 91853cf to 1eae565 Compare February 16, 2022 23:52
maxime-rainville
maxime-rainville requested changes Feb 17, 2022
View reviewed changes
src/Core/Manifest/VersionProvider.php Show resolved Hide resolved
src/Core/Manifest/VersionProvider.php Show resolved Hide resolved
src/Core/Manifest/VersionProvider.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/4/meta-generator branch from 1eae565 to 4aab70d Compare February 17, 2022 22:34
@emteknetnz emteknetnz force-pushed the pulls/4/meta-generator branch from 4aab70d to 2041658 Compare March 4, 2022 01:48
@emteknetnz emteknetnz force-pushed the pulls/4/meta-generator branch from 2041658 to 380f841 Compare March 4, 2022 01:55
maxime-rainville
maxime-rainville requested changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor doc changes.

docs/en/02_Developer_Guides/01_Templates/02_Common_Variables.md Show resolved Hide resolved
docs/en/02_Developer_Guides/01_Templates/02_Common_Variables.md Outdated Show resolved Hide resolved
docs/en/04_Changelogs/4.11.0.md Outdated Show resolved Hide resolved
docs/en/04_Changelogs/4.11.0.md Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/4/meta-generator branch from 380f841 to f488f38 Compare March 8, 2022 00:48
@emteknetnz
Copy link
Member Author

Updated

@maxime-rainville
Copy link
Contributor

Me confused.

PHP Fatal error: Declaration of SilverStripe\Control\Tests\Email\EmailTest::setUp() must be compatible with SilverStripe\Dev\SapphireTest::setUp(): void in /home/travis/build/silverstripe/silverstripe-framework/tests/php/Control/Email/EmailTest.php on line 28

Fatal error: Declaration of SilverStripe\Control\Tests\Email\EmailTest::setUp() must be compatible with SilverStripe\Dev\SapphireTest::setUp(): void in /home/travis/build/silverstripe/silverstripe-framework/tests/php/Control/Email/EmailTest.php on line 28

@emteknetnz
Copy link
Member Author

Was fixed here #10252

@maxime-rainville maxime-rainville merged commit 78dcfd2 into silverstripe:4 Mar 9, 2022
@maxime-rainville maxime-rainville deleted the pulls/4/meta-generator branch March 9, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli left review comments

@kinglozzer kinglozzer kinglozzer left review comments

@maxime-rainville maxime-rainville maxime-rainville approved these changes

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emteknetnz @maxime-rainville @michalkleiner @kinglozzer @GuySartorelli