NEW Include version number in meta generator tag

[emteknetnz]

Issue #2708

Will require this PR to be merged first

[maxime-rainville]

Why not just keep tho old behavior and not output the meta tag if `meta_generator' is blank?

[emteknetnz]

That behavior is still there, if you config private static $meta_generator to a blank string then there won't be a meta tag for generator

i.e.

    public function MetaComponents()
...
        $generator = $this->getGenerator();
        if ($generator) {
            $tags['generator'] = [
...
    }

    private function getGenerator(): string
    {
        $generator = trim(Config::inst()->get(self::class, 'meta_generator'));
        if ($generator === '') {
            return '';
        }
        if (self::config()->get('show_meta_generator_version')) {
        ...
    }

[maxime-rainville]

I just don't understand what kind of user would say "I don't want the version number there, but I'm fine advertising the site uses Silverstripe CMS".

My gut feeling is the vast majority of users who are bothered by the version number will want to remove the entire meta tag.

[emteknetnz]

Probably very few users. However private static $meta_generator = 'Silverstripe CMS'; is currently a configurable string, so we do support changing this to something else e.g. 'CMS from Mars'.

If people want to report this as a different CMS for whatever reason, then I can see why they wouldn't want to include the version number

I'm not hugely attached to having these two things separately configurable, though I also don't see it as much extra hassle

[maxime-rainville]

Sorry ... meant to reject.

[maxime-rainville]

Tested it locally and it works fine. I hacked my composer.lock file to test that the version is being picked up properly.

There's the slight question about what to do with "4.x-dev". Since this doesn't match the expected regex format, it just comes back with nothing. The help menu in the CMS renders "4.x".

The behaviour in this PR is pretty defensible and I don't have any beef with it. Just think it's worth pointing out this is happening.

[maxime-rainville]

Actually, the composer file needs to be updated to require framework ^4.11 since we rely on the new API being present.

[emteknetnz]

it just comes back with nothing

That was intentional, some people will be running forks of framework, don't want those being reported. I'll add an inline note about this

composer.json has the ^4.11 requirement

[maxime-rainville]

Framework PR has been merged which should make this PR green. Just restarted the build