Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embed Shortcodes break Text::Summary() method. #2929

Closed
quamsta opened this issue Mar 6, 2014 · 2 comments
Closed

embed Shortcodes break Text::Summary() method. #2929

quamsta opened this issue Mar 6, 2014 · 2 comments
Labels
impact/critical

Comments

@quamsta
Copy link
Contributor

quamsta commented Mar 6, 2014

We just found that when users were searching for a page on one of our sites that the search results would break when we were using
$Content.Summary(30) in the Page_results.ss template. We were getting this error:

Fatal error: Call to a member function appendChild() on a non-object in /xx/framework/parsers/ShortcodeParser.php on line 124

We're pretty sure this was being caused by at least one correctly formed [embed] shortcode in the content of the results returned.
@sminnee sminnee mentioned this issue May 17, 2016
Closed
@tractorcow tractorcow mentioned this issue Jun 7, 2016
Merged
@tractorcow
Copy link
Contributor

Will try to address in #5653

tractorcow pushed a commit to tractorcow/silverstripe-framework that referenced this issue Jun 15, 2016
Fix DBHTMLText summaries
cdfcffb 
Fixes silverstripe#2929
Fixes silverstripe#1381
Fixes silverstripe#5547
Fixes silverstripe#1751
tractorcow pushed a commit to tractorcow/silverstripe-framework that referenced this issue Jun 17, 2016
Fix DBHTMLText summaries
7d41650 
Fixes silverstripe#2929
Fixes silverstripe#1381
Fixes silverstripe#5547
Fixes silverstripe#1751
tractorcow pushed a commit to tractorcow/silverstripe-framework that referenced this issue Jun 17, 2016
API / BUG Fix DBField summary methods
3995b13 
Cleanup DBField subclasses
Fixes silverstripe#2929
Fixes silverstripe#1381
Fixes silverstripe#5547
Fixes silverstripe#1751
tractorcow pushed a commit to tractorcow/silverstripe-framework that referenced this issue Jun 17, 2016
API / BUG Fix DBField summary methods
178507c 
Cleanup DBField subclasses
Fixes silverstripe#2929
Fixes silverstripe#1381
Fixes silverstripe#5547
Fixes silverstripe#1751
tractorcow pushed a commit to tractorcow/silverstripe-framework that referenced this issue Jun 17, 2016
API / BUG Fix DBField summary methods
ba02b92 
Cleanup DBField subclasses
Fixes silverstripe#2929
Fixes silverstripe#1381
Fixes silverstripe#5547
Fixes silverstripe#1751
tractorcow pushed a commit to tractorcow/silverstripe-framework that referenced this issue Jul 12, 2016
API / BUG Fix DBField summary methods
f7dd170 
Cleanup DBField subclasses
Fixes silverstripe#2929
Fixes silverstripe#1381
Fixes silverstripe#5547
Fixes silverstripe#1751
@tractorcow
Copy link
Contributor

Fixed with #5653 :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact/critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simonwelsh @quamsta @tractorcow