Shortcodes not replaced in FulltextSearch results

[g4b0]

As in subject, search results output is served without replacing shortcodes with corresponding URL (SS 3.1.0-beta2 git pulled right now)

[dhensby]

@g4b0 hmm, should they be? I have shortcodes to embed YouTube videos, add Google Maps and so on. This kind of media I wouldn't want to show in search results...

Perhaps you should override this on a per site basis?

However, if the ShortCodes still show (aren't stripped out) that is indeed a bug - and one that needs to be decided on how it's fixed (ie: Remove or parse)

[g4b0]

@dhensby you're right, maybe the correct way to fix the bug is to remove shortcodes in search results rather then parse them. @chillu what do you think about that?

[chillu]

Its use case dependent, but removing them would be a good default.

[hafriedlander]

I suspect the results are either not being cast as HTMLText, or aren't valid HTML.

If it's the second, you should be able to set ShortcodeParser::$error_behavior to ShortcodeParser::STRIP to have it remove invalid shortcodes, but currently it won't work properly if the HTML can't even be parsed.

[g4b0]

I tryied with ShortcodeParser::$error_behavior setted to ShortcodeParser::STRIP, but it does not strip external links:

STRIP:

Benvenuto in SilverStripe! Questa è l'homepage di default. Puoi modificare questa pagina aprendo il CMS. Puoi visualizzare adesso la documentazione di sviluppo[http://doc.silverstripe.com], o iniziaren i tutorial.[http://doc.silverstripe.com/doku.php?id=tutorials]

LEAVE:

Benvenuto in SilverStripe! Questa è l'homepage di default. Puoi modificare questa pagina aprendo il CMS[admin/]. Puoi visualizzare adesso la documentazione di sviluppo[http://doc.silverstripe.com], o iniziaren i tutorial.[http://doc.silverstripe.com/doku.php?id=tutorials]

only [admin/] was stripped form my test search

[tractorcow]

Fixed with #5653 :D