Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Silverstripe 5 #50

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Upgrade to Silverstripe 5 #50

merged 4 commits into from
Aug 5, 2024

Conversation

wilr
Copy link
Member

@wilr wilr commented Jul 3, 2024

Description

Upgrade to Silverstripe 5

Manual testing steps

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@wilr
Copy link
Member Author

wilr commented Jul 3, 2024

Note if Silverstripe limited no longer wishes to support the module as per the readme I'm happy to transfer to my handle as it is still one of our used modules. Or I can remove the notice now.

@GuySartorelli
Copy link
Member

Hiya,
Sorry it's taken so long to comment on this.

The 4 branch is still supported for security fixes only, and we've committed to not doing any non-security patches on this branch.

That said, we don't have any commercial support for this module for CMS 5. If you'd like to maintain this module going forward, we'd be happy for you to do so, starting from a new major release on a new 5 branch. You should already have maintainer access as a core committer.

@wilr wilr changed the base branch from 4 to 5 August 5, 2024 00:14
@wilr wilr merged commit 9f00f2c into silverstripe:5 Aug 5, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants