Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tijsverkoyen/akismet constraint is too strict and might not work on PHP8 #44

Open
1 task
maxime-rainville opened this issue Feb 3, 2023 · 1 comment
Open
1 task

Comments

@maxime-rainville
Copy link

Someone has reported that tijsverkoyen/akismet 1.1.0 doesn't work with PHP8. There's apparently a commit in tijsverkoyen/akismet dev-master that allows it to work with PHP8.

There's also a v1.1.1 tag that in theory could be installed which our very strict constraint won't allow.

"tijsverkoyen/akismet": "1.1.0",

Acceptance criteria

  • We've validated that silverstripe/silverstripe-akismet works on PHP8 and PHP8.1.
@maxime-rainville
Copy link
Author

Looks like this is this is the commit that never was shipped that's causing issues: tijsverkoyen/Akismet@a42da18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants