NEW Wait for promises before submitting forms #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/2/always-inline-submit-elements
branch
4 times, most recently
from
b9c6bf5 to
21713fe
Compare
emteknetnz
commented
Jun 26, 2024
emteknetnz
commented
Jun 26, 2024
emteknetnz
commented
Jun 26, 2024
emteknetnz
force-pushed
the
pulls/2/always-inline-submit-elements
branch
from
21713fe to
16702b3
Compare
Closed
9 tasks
emteknetnz
force-pushed
the
pulls/2/always-inline-submit-elements
branch
from
16702b3 to
e5e01ae
Compare
|
Broken --prefer-lowest build is unrelated and will be fixed in silverstripe/gha-ci#132 |
GuySartorelli
requested changes
Jul 9, 2024
emteknetnz
force-pushed
the
pulls/2/always-inline-submit-elements
branch
from
e5e01ae to
e789c40
Compare
GuySartorelli
approved these changes
Jul 11, 2024
emteknetnz
force-pushed
the
pulls/2/always-inline-submit-elements
branch
from
e789c40 to
2a14985
Compare
emteknetnz
commented
Jul 18, 2024
GuySartorelli
approved these changes
Jul 18, 2024
emteknetnz
force-pushed
the
pulls/2/always-inline-submit-elements
branch
from
2a14985 to
be057e5
Compare
emteknetnz
commented
Jul 18, 2024
emteknetnz
force-pushed
the
pulls/2/always-inline-submit-elements
branch
from
be057e5 to
4140199
Compare
GuySartorelli
approved these changes
Jul 21, 2024
emteknetnz
force-pushed
the
pulls/2/always-inline-submit-elements
branch
from
4140199 to
7e4d882
Compare
|
CI failure will be resolved as part of silverstripe/.github#285 |
|
Will rerun CI after #1792 is merged |
|
Can you please rebase this? Looks like it needs a rebase to pick up the missing |
emteknetnz
force-pushed
the
pulls/2/always-inline-submit-elements
branch
from
7e4d882 to
ef32740
Compare
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-elemental#1215