Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double .x-dev requirements in --prefer-lowest builds #132

Closed
emteknetnz opened this issue Jul 4, 2024 · 4 comments
Closed

Double .x-dev requirements in --prefer-lowest builds #132

emteknetnz opened this issue Jul 4, 2024 · 4 comments
Assignees
@emteknetnz
Labels
type/bug

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Jul 4, 2024 •
edited
Loading

After the change in #131 there are now some invalid double .x-dev requirements e.g. 5.x-dev.x-dev for example https://github.com/silverstripe/silverstripe-admin/actions/runs/9789724139/job/27029957813?pr=1792#step:9:355

PR
@emteknetnz emteknetnz mentioned this issue Jul 4, 2024
Merged
@emteknetnz emteknetnz assigned emteknetnz and unassigned emteknetnz Jul 4, 2024
@emteknetnz emteknetnz mentioned this issue Jul 4, 2024
Merged
@GuySartorelli
Copy link
Member

PR merged
Reassigning to Steve to double check that resolved the problem

@GuySartorelli GuySartorelli mentioned this issue Jul 7, 2024
Merged
@GuySartorelli
Copy link
Member

Still got massive prefer-lowest failures across the board.

@emteknetnz emteknetnz mentioned this issue Jul 8, 2024
Merged
@GuySartorelli
Copy link
Member

PR merged
Reassigning to Steve to double check that resolved the problem

@emteknetnz
Copy link
Member Author

Resolved. There are still a couple of failures, though they are actual --prefer-lowest failures rather than CI simply not running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emteknetnz emteknetnz

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli