Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Use the lowest possible version of installer for --prefer-lowest builds #131

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jul 3, 2024

Issue silverstripe/gha-generate-matrix#93

Tested on https://github.com/emteknetnz/silverstripe-elemental/actions/runs/9771968678/job/26975579646 running against the 5 branch of elemental

--prefer-lowest build now uses installer 5.1.x-dev, while all other builds use installer 5.x-dev

@emteknetnz emteknetnz force-pushed the pulls/1/prefer-lowest branch 3 times, most recently from df754bf to e019765 Compare July 3, 2024 21:56
@emteknetnz emteknetnz force-pushed the pulls/1/prefer-lowest branch from e019765 to 7998566 Compare July 3, 2024 22:05
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit bc75912 into silverstripe:1 Jul 3, 2024
4 checks passed
@GuySartorelli GuySartorelli deleted the pulls/1/prefer-lowest branch July 3, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants