Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Behat test cases for GridField navigation #1338

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented Aug 5, 2022

Description

Moved Behat test cases for GridField navigation in the new file gridfield-navigation.feature.
Removed scenario for navigation from gridfield-search.feature.

Parent issue

@sabina-talipova
Copy link
Contributor Author

sabina-talipova commented Aug 5, 2022

Fails on behat test "And the maximum "5" items per page".
Code base for this step in silverstripe/silverstripe-behat-extension#219

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you moving scenarios out of the "search" feature and into the "navigation" feature? How do the two differ?

tests/behat/features/gridfield-navigation.feature Outdated Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/1/better-button-keep-state branch 5 times, most recently from 46047e4 to a639a39 Compare August 9, 2022 03:07
@sabina-talipova sabina-talipova force-pushed the pulls/1/better-button-keep-state branch 2 times, most recently from 87465a4 to 64ac4bc Compare August 15, 2022 20:56
@sabina-talipova sabina-talipova force-pushed the pulls/1/better-button-keep-state branch from 64ac4bc to 13e4f71 Compare August 18, 2022 01:59
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests pass with the changes and new admin locally.
Just a couple of suggestions to make the tests more robust against false positives.

tests/behat/features/gridfield-navigation.feature Outdated Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/1/better-button-keep-state branch from 13e4f71 to c2e8b9f Compare August 22, 2022 01:03
@GuySartorelli
Copy link
Member

The behat failures are unrelated to this PR and are fixed in #1345

@GuySartorelli GuySartorelli merged commit 9369284 into silverstripe:1 Aug 22, 2022
@GuySartorelli GuySartorelli deleted the pulls/1/better-button-keep-state branch August 22, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants