-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Behat test cases for GridField navigation #1338
ENH Behat test cases for GridField navigation #1338
Conversation
Fails on behat test "And the maximum "5" items per page". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you moving scenarios out of the "search" feature and into the "navigation" feature? How do the two differ?
46047e4
to
a639a39
Compare
87465a4
to
64ac4bc
Compare
64ac4bc
to
13e4f71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests pass with the changes and new admin locally.
Just a couple of suggestions to make the tests more robust against false positives.
13e4f71
to
c2e8b9f
Compare
The behat failures are unrelated to this PR and are fixed in #1345 |
Description
Moved Behat test cases for GridField navigation in the new file
gridfield-navigation.feature
.Removed scenario for navigation from
gridfield-search.feature
.Parent issue