Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridField. Better button issues. #1315

Closed
4 tasks done
sabina-talipova opened this issue Jun 30, 2022 · 1 comment
Closed
4 tasks done

GridField. Better button issues. #1315

sabina-talipova opened this issue Jun 30, 2022 · 1 comment

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Jun 30, 2022

Description

There is a problem with the "Previous" and "Next" buttons in a child element.

  • Does not navigate past the first two items on the next page when using this navigation to navigate from an item listed on the first page to an item listed on the second page.
  • This element does not support filtered and sorted lists.

SPIKE (for context)

silverstripeltd/product-issues#254

AC's

  • Once you click on a specific item, it should still keep track of the parent GridField state, so better buttons knows how to filter the list
  • When user reaches last item in the GridField list on particular page, except last one, and they click on 'Next' button they should get the first item of GridField list with all applied filters and sorting on the next page.
  • When user reaches first item in the GridField list on particular page, except first one, and they click on 'Previous' button they should get the last item of GridField list with all applied filters and sorting on the previous page.
  • The last and first item in the gridfield don't loop.

Notes

  • When viewing a specific item, it's not clear that it's in a filtered list. Maybe we should have a foolow up card on this.
  • Concurrent editing of the Gridifeld will lead to weird results. There's not much we can do about that right now.

Related issue

PR's

@GuySartorelli
Copy link
Member

All PRs merged, no outstanding ACs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants