Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Fix behat tests - explicitly use the advanced filter input #1336

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

GuySartorelli
Copy link
Member

Fixes https://github.com/silverstripe/silverstripe-admin/runs/7602647956?check_suite_focus=true

Form field with id|name|label|value "SearchBox__FirstName" not found. (Behat\Mink\Exception\ElementNotFoundException)

Form field with id|name|label|value "SearchBox__Name" not found. (Behat\Mink\Exception\ElementNotFoundException)

SearchBox__ is the prefix for the general search field. Search__ is the prefix for the advanced filter input fields. These tests have been using the wrong field this whole time.
This has come up because the general search field name is now q (so SearchBox__q)

@emteknetnz emteknetnz merged commit 38c1ae2 into silverstripe:1 Aug 1, 2022
@emteknetnz emteknetnz deleted the pulls/1/fix-behat branch August 1, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants